fix: don't report visibility errors when elaborating comptime value #6498
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljklein
requested changes
Nov 13, 2024
| @@ -493,3 +493,28 @@ fn does_not_error_if_referring_to_top_level_private_module_via_crate() { | |||
| "#; | |||
| assert_no_errors(src); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn visibility_bug_inside_comptime() { | |||
There was a problem hiding this comment.
Please test that running a function that accesses a private struct member from a comptime context still fails, e.g.
mod foo {
pub struct Foo {
inner: Field,
}
}
use foo::Foo;
fn main() {
let _ = comptime { Foo { inner: 5 } };
}- Deriving a function that references a private member from
comptime, e.g.fn bar(inner: Field) -> Foo { Foo { inner } }, fails with "innernot in scope" when run outsidemod foo.
| @@ -509,6 +509,10 @@ impl<'context> Elaborator<'context> { | |||
| visibility: ItemVisibility, | |||
| span: Span, | |||
| ) { | |||
| if self.silence_field_visibility_errors > 0 { | |||
There was a problem hiding this comment.
Could other types of visibility, e.g. for traits, cause similar issues? If so, could you make a follow up issue for them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #6485
Summary
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.