Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Support type (alias) rename #5358

Closed
Tracked by #4191
asterite opened this issue Jun 28, 2024 · 0 comments
Closed
Tracked by #4191

LSP: Support type (alias) rename #5358

asterite opened this issue Jun 28, 2024 · 0 comments
Assignees
@asterite
Labels
lsp Language Server Protocol

Comments

@asterite
Copy link
Collaborator

asterite commented Jun 28, 2024 •
edited
Loading

Problem

PR #4294 adds support for renaming all references to a function however it does not support other items such as type aliases: #4294 (comment)

We should add support for this.
@asterite asterite added enhancement New feature or request lsp Language Server Protocol and removed enhancement New feature or request labels Jun 28, 2024
@asterite asterite self-assigned this Jun 28, 2024
@asterite asterite changed the title LSP: Support type (alias) renames LSP: Support type (alias) rename Jun 28, 2024
This was referenced Jun 28, 2024
Merged
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 8, 2024
@asterite
feat: lsp rename/find-all-references for type aliases (#5414)
24c621f 
# Description

## Problem

Resolves #5358

## Summary

Based on top of #5411

Implements the usual rename/find-all-references but this time for type
aliases.

I noticed some things related to name locations could be simplified (not
stored in a duplicate way) so there's also a small simplification here.


https://github.com/noir-lang/noir/assets/209371/77508029-7002-4708-9cc1-24fc879630db

## Additional Context

None.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asterite asterite

Labels
lsp Language Server Protocol
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asterite