Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

children does not work #1

Open
atmin opened this issue Jul 12, 2016 · 1 comment
Open

children does not work #1

atmin opened this issue Jul 12, 2016 · 1 comment

Comments

@atmin
Copy link

atmin commented Jul 12, 2016

props.children does not work, so currently the README example is a bit misleading by using {children}.

Great lib, nevertheless. data-* properties already provide a seamless way for ServerSideTemplatingEngine--React interaction.

@cchamberlain
Copy link
Member

Sorry for the 3 month late response.. I have been missing some notifications.

The legacy application I was using this in outgrew it's need for this hence no updates. I can see that I did indeed write the code to snag the innerHTML off an element and inject it however it is commented out. I have no recollection why I did this other than I had no need for it in my app and did not pursue. I'll try and get the readme updated to reflect or possibly add the support in near future. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants