Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain languages break the max height of the search bar #6841

Open
ovflowd opened this issue Jun 17, 2024 · 3 comments · May be fixed by #6842 or #6904
Open

Certain languages break the max height of the search bar #6841

ovflowd opened this issue Jun 17, 2024 · 3 comments · May be fixed by #6842 or #6904
Labels
bug

Comments

@ovflowd
Copy link
Member

ovflowd commented Jun 17, 2024

URL:

https://nodejs.org/pt or https://nodejs.org/fr

Browser Name:

Chrome

Browser Version:

N/A

Operating System:

N/A

How to reproduce the issue:

  1. Switch to a Localized Language
  2. You'll notice that the search bar height is not respected
@ovflowd ovflowd added the bug label Jun 17, 2024
@nilkhankari
Copy link

Can I work on resolving this issue?

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 17, 2024 •
edited
Loading

Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time.
Reference 🍪 https://www.redhat.com/en/blog/dont-lick-cookie

As an implementation suggestion, I'd explore expanding the available space on large viewports. There is plenty.

image

@nilkhankari
Copy link

Thanks! Yes, we can fix this by increasing the width. I'll work on it and submit a PR as soon as possible.

nilkhankari added a commit to nilkhankari/nodejs.org that referenced this issue Jun 18, 2024
@nilkhankari
Fix: Certain languages break the max height of the search bar nodejs#…
b5ecba8 
…6841
nilkhankari added a commit to nilkhankari/nodejs.org that referenced this issue Jun 18, 2024
@nilkhankari
Fix: Certain languages break the max height of the search bar nodejs#…
b9bc204 
…6841
nilkhankari added a commit to nilkhankari/nodejs.org that referenced this issue Jun 18, 2024
@nilkhankari
Fix: Certain languages break the max height of the search bar nodejs#…
a1bf7e3 
…6841
nilkhankari added a commit to nilkhankari/nodejs.org that referenced this issue Jun 18, 2024
@nilkhankari
Fix: Certain languages break the max height of the search bar nodejs#…
1d352eb 
…6841
@nilkhankari nilkhankari linked a pull request Jun 18, 2024 that will close this issue
Open
5 tasks
nilkhankari added a commit to nilkhankari/nodejs.org that referenced this issue Jun 21, 2024
@nilkhankari
Fix: Certain languages break the max height of the search bar nodejs#…
a093f89 
…6841
@mikeesto mikeesto mentioned this issue Jul 5, 2024
Closed
@nazarepiedady nazarepiedady linked a pull request Jul 5, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@bmuenzenmeyer @ovflowd @nilkhankari