Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer missing on Learn layout #6829

Open
bmuenzenmeyer opened this issue Jun 10, 2024 · 4 comments
Open

Footer missing on Learn layout #6829

bmuenzenmeyer opened this issue Jun 10, 2024 · 4 comments
Labels
bug design good first issue Issues for newcomers

Comments

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 10, 2024 •
edited
Loading

https://nodejs.org/en/learn/getting-started/introduction-to-nodejs

Screenshot_20240610_181426_Chrome.jpg
@mikeesto
Copy link
Member

Same on About too https://nodejs.org/en/about

@Wellitsabhi
Copy link

footer missing in 'About and 'Learn" layout , already on it,raising PR

Wellitsabhi added a commit to Wellitsabhi/nodejs.org-fork that referenced this issue Jun 11, 2024
@Wellitsabhi
issue nodejs#6829 fixed
017d6f7
@Wellitsabhi Wellitsabhi mentioned this issue Jun 11, 2024
Closed
5 tasks
@ovflowd
Copy link
Member

ovflowd commented Jun 17, 2024

Id say these pages are following the figmas, which have no footer. Now, not sure if we should add or not 🤷

Im fine eitherways.

@bmuenzenmeyer
Copy link
Collaborator Author

I noticed that too but it looks REALLY out of place to me to selectively render a global component. I am surprised it didn't come up earlier, TBH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design good first issue Issues for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Footer added Wellitsabhi/nodejs.org-fork
4 participants
@bmuenzenmeyer @ovflowd @mikeesto @Wellitsabhi