From 2a654e47282c8b2847422f2d4c444180f214ab5c Mon Sep 17 00:00:00 2001 From: Evan Lucas Date: Wed, 19 Oct 2016 19:27:08 -0500 Subject: [PATCH] test: fix flaky test by removing timer This fixes one of the tests that has been failing on CI on freebsd for a bit by removing an unnecessary timer. PR-URL: https://github.com/nodejs/node/pull/9199 Fixes: https://github.com/nodejs/node/issues/7929 Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott --- test/parallel/test-dgram-send-callback-buffer.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-dgram-send-callback-buffer.js b/test/parallel/test-dgram-send-callback-buffer.js index e2966645d927ae..e0b2a581bf74aa 100644 --- a/test/parallel/test-dgram-send-callback-buffer.js +++ b/test/parallel/test-dgram-send-callback-buffer.js @@ -9,14 +9,9 @@ const client = dgram.createSocket('udp4'); const buf = Buffer.allocUnsafe(256); const onMessage = common.mustCall(function(err, bytes) { - assert.strictEqual(err, null); - assert.equal(bytes, buf.length); - clearTimeout(timer); + assert.ifError(err); + assert.strictEqual(bytes, buf.length); client.close(); }); -const timer = setTimeout(function() { - throw new Error('Timeout'); -}, common.platformTimeout(200)); - client.send(buf, common.PORT, common.localhostIPv4, onMessage);