Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currentSession doesn't check if token is still valid on Solid server. #127

Open
jairo-campos-JD opened this issue Jun 20, 2019 · 2 comments
Labels
triage Issues that need team review

Comments

@jairo-campos-JD
Copy link

jairo-campos-JD commented Jun 20, 2019

Current Functionality: tracksession check if there is a token in the local storage to validate if the user is logging or not.

Possible issue: Apps doesn't know when the token is invalid to redirect the user to log in. We could use 401 response to fix it but we couldn't make a difference between a token or permissions error.

Solution: New functionality to check if the current session(token) is valid on Solid server and make differences when there is an error for permissions or token.

cc: @RubenVerborgh

@RubenVerborgh RubenVerborgh changed the title tracksession doesn't check is token is still valid on Solid server. currentSession doesn't check is token is still valid on Solid server. Jun 20, 2019
@RubenVerborgh
Copy link
Contributor

Technically currentSession of webid-oidc.js.

Main problem is that token renewal is not implemented in the OIDC libraries we use.

@justinwb justinwb changed the title currentSession doesn't check is token is still valid on Solid server. currentSession doesn't check if token is still valid on Solid server. Jun 20, 2019
@jaxoncreed jaxoncreed added the triage Issues that need team review label Jun 28, 2019
@matthieu-fesselier
Copy link

Interested in this too!

I'm not sure, but token renewal is here where there is no token on the client and we need to get a new one from the servern right?

What if there is still a token on the client but it's not valid anymore on the server? Can we check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues that need team review
Projects
None yet
Development

No branches or pull requests

4 participants