Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow options like max (age) to be passed from issueFor() to issue() #24

Open
gatos-jd opened this issue May 4, 2019 · 1 comment
Open

Comments

@gatos-jd
Copy link

gatos-jd commented May 4, 2019

https://github.com/solid/oidc-rp/blob/dcae9cbb484f2aa9b913bd6e7db8ab8d98373186/src/PoPToken.js#L36

solid-auth-client uses issueFor() to generate a PoPToken. There appears to be no way to pass the max option through issueFor() to issue() to change the default age of the token generated from DEFAULT_MAX_AGE to anything else.

In general, it would probably be good to have a version of issueFor() that takes an option hash and passes the values through to the issue() call.

@dmitrizagidulin
Copy link
Contributor

👍 agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants