Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be using absolute URLs according to the spec #8

Open
michielbdejong opened this issue May 7, 2019 · 3 comments
Open

should be using absolute URLs according to the spec #8

michielbdejong opened this issue May 7, 2019 · 3 comments

Comments

@michielbdejong
Copy link
Member

https://github.com/solid/solid-spec/blob/master/api-websockets.md
So sub https://localhost:8443/public/ and not sub /public/ or sub public

@RubenVerborgh
Copy link

Agreed, but a warning for implementers: the module might not know the external URL (might be behind a proxy etc.), which is part of (for instance) NSS config.

@michielbdejong
Copy link
Member Author

Yes, in that case it should look at the X-Forwarded-Host header, I think? The LDP server probably also wants to know which absolute URLs it can consider as local.

@RubenVerborgh
Copy link

Indeed, that one and related headers (https://tools.ietf.org/html/rfc7239).
Also theoretically need to distinguish between HTTP and HTTPS, but we should be able to safely assume the latter (although you never know in test environments).

Trouble is that NSS will prefer its configured URL and the Host header over these, but that's probably a NSS problem then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants