Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issuer URIs with a path part don't work #1265

Open
zenomt opened this issue Jul 20, 2019 · 2 comments
Open

issuer URIs with a path part don't work #1265

zenomt opened this issue Jul 20, 2019 · 2 comments
Labels

Comments

@zenomt
Copy link

zenomt commented Jul 20, 2019

i originally opened this as nodeSolidServer/oidc-auth-manager#44 but perhaps i should have started here to target the right audience.

oidc-auth-mananger seems to make an invalid assumption that all OIDC Issuers are URIs with an empty path part. if a webid has an OIDC Issuer URI with a path part (like my webid https://zenomt.zenomt.com/card.ttl#me with issuer https://zenomt.com/oidc/), it can never be matched against the id_token iss claim because the discovered issuer URI is reduced to its origin before being compared. see these lines in preferred-provider.js.

OIDC Issuers are allowed to have path parts.

@jaxoncreed
Copy link
Contributor

Good point. This should be fixed, though until we encounter a solid-compatible openid-provider this will be a low priority.

@zenomt
Copy link
Author

zenomt commented Sep 27, 2019

@jaxoncreed my own OpenID provider and my own webid would be "Solid-compatible" if this issue was fixed.

@jaxoncreed jaxoncreed added the bug label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants