Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the profile announce the oidcIssuer? #1254

Open
michielbdejong opened this issue Jul 4, 2019 · 3 comments
Open

should the profile announce the oidcIssuer? #1254

michielbdejong opened this issue Jul 4, 2019 · 3 comments

Comments

@jaxoncreed
Copy link
Contributor

So right now there are two ways that the profile can announce the oidc issuer. The first is the one linked above, and that works well for WebIDs that are not on Solid servers. The other way (which is the way it works on NSS) is to provide the issuer in the Link header.

Though I do agree that maybe this should be brought into question. The Link header isn't very transparent and maybe all profiles should just include the issuer including the ones hosted on a Solid server.

@elf-pavlik
Copy link
Contributor

We have marked Link header discover as at risk: https://github.com/solid/webid-oidc-spec#issuer-discovery-from-link-header

I recall that some things also check /.well-known/openid-configuration, see nodeSolidServer/oidc-auth-manager#36

AFAIK discovery from WebID Profile still stays broken in solid-auth-client nodeSolidServer/solid-auth-client#107

@jaxoncreed
Copy link
Contributor

Should a pull request be made to remove the link header discover? I agree that it's not as good as just putting it in your profile document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants