Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getTrustedModesForOrigin #22

Open
michielbdejong opened this issue Mar 15, 2019 · 0 comments
Open

Refactor getTrustedModesForOrigin #22

michielbdejong opened this issue Mar 15, 2019 · 0 comments

Comments

@michielbdejong
Copy link
Member

You now need to call this library twice, once to get the trusted modes (passing it a fetcher callback, which is also a bit of a muddled boundary), and then to determine access.
The two functions even have a chunk of identical code at the beginning, so this can definitely be improved with a refactor.
michielbdejong added a commit to michielbdejong/acl-check that referenced this issue Mar 15, 2019
@michielbdejong
FIXME note about nodeSolidServer#22
844bd5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michielbdejong