Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing packages when doing package install #544

Open
nirvedhmeshram opened this issue Nov 15, 2024 · 2 comments
Open

Missing packages when doing package install #544

nirvedhmeshram opened this issue Nov 15, 2024 · 2 comments

Comments

@nirvedhmeshram
Copy link

nirvedhmeshram commented Nov 15, 2024

Following https://github.com/nod-ai/shark-ai/blob/main/docs/user_guide.md
I had to separately install these pip packages

pip install fastapi
pip install uvicorn
pip install aiohttp

Additionally

pip install shortfin --upgrade --pre -f https://github.com/nod-ai/SHARK-Platform/releases/expanded_assets/dev-wheels

broke the dependecy for me

Looking in links: https://github.com/nod-ai/SHARK-Platform/releases/expanded_assets/dev-wheels
Requirement already satisfied: shortfin in ./3.11.venv/lib/python3.11/site-packages (2.9.1)
Collecting shortfin
 Downloading https://github.com/nod-ai/shark-ai/releases/download/dev-wheels/shortfin-3.0.0rc20241115-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.5 MB)
    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.5/2.5 MB 20.0 MB/s eta 0:00:00
Installing collected packages: shortfin
 Attempting uninstall: shortfin
   Found existing installation: shortfin 2.9.1
   Uninstalling shortfin-2.9.1:
     Successfully uninstalled shortfin-2.9.1
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
shark-ai 2.9.1 requires shortfin==2.9.1, but you have shortfin 3.0.0rc20241115 which is incompatible.
Successfully installed shortfin-3.0.0rc20241115

[notice] A new release of pip is available: 24.0 -> 24.3.1
[notice] To update, run: pip install --upgrade pip

I realized that for me I didnt need this part and use the package that comes by defualt, but hopefully users dont get tripped up by that.

@ScottTodd
Copy link
Member

First issue is a dup of #533, which was already fixed by #529

@ScottTodd
Copy link
Member

For the second issue... @marbre we should sketch out the upgrade path from stable shark-ai to nightly... maybe we just need a nightly shark-ai package too, or users may need to uninstall shark-ai in order to use loose versions of shortfin, sharktank, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants