-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure AIE through control packets #714
Comments
The router will need to be updated again (well depending on how much we're gonna copy paste from mlir-aie). |
Yeah, I was wondering about this. What changes would be needed in the router? |
Some of this stuff https://github.com/Xilinx/mlir-aie/pulls?q=is%3Apr+is%3Aclosed+author%3AYu-Zhewen (starting with Xilinx/mlir-aie#1643). |
This PR introduces the `amdaie.flow` operation (in consistency with `aie.flow`). This operation represents connections between ports/channels on tiles in the array and is lowered to `aie.flow` for routing. This idea is to lower `amdaie.connection` to `amdaie.flow` + DMA operations, however this PR goes halfway by creating `amdaie.flow` operations, while still keeping a reference inside `amdaie.connection` as the latter is still needed inside `LowerToAIE` for lowering to the AIE dialect DMA operations. This will be cleaned up in the future, but for now, this enables me to start adding routes for control packets in conjunction with data routes for #714.
As enabling general AIE configuration through control packets will be a heavy lift, I intend to approach this in phases:
For the initial POC to program shim DMAs using control packets, I believe the following pieces will be needed:
AMDAIEStatetfulTransform
to enable packet flows. As we're trying to get rid of this pass and AIE dialect ops, I will try to extract the flow logic from it so that the necessary transformations for enabling packet flows can be done on AMDAIE ops. Therefore, the following changes will be needed:AMDAIEStatefulTransform
and moving it up intoAMDAIE
transformations.After this initial POC, I will move on to phases 2 and 3.
Resources:
aiex.npu.dma_mempcy_nd
Xilinx/mlir-aie#1671The text was updated successfully, but these errors were encountered: