add support for external weights #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-garvey
force-pushed
the
external_weight_fixes
branch
10 times, most recently
from
33e5d63
to
ba77cf8
Compare
dan-garvey
force-pushed
the
external_weight_fixes
branch
11 times, most recently
from
9a2a223
to
08998db
Compare
dan-garvey
force-pushed
the
external_weight_fixes
branch
6 times, most recently
from
664390d
to
26294a9
Compare
dan-garvey
force-pushed
the
external_weight_fixes
branch
3 times, most recently
from
be2086c
to
bc7a5fa
Compare
dan-garvey
force-pushed
the
external_weight_fixes
branch
from
bc7a5fa
to
f6d1a9d
Compare
monorimet
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
LGTM. May revive pytests with #1904 if we need the extra testing on the model import side.
Next up: SHARK core python API bulldozing and -- anything we want to keep should just go in apps
Ideally we implement a good way to manage the various tests for small APIs utility functions, and UI features incoming -- this was missing from Studio 1.0 and it hurt quite a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@monorimet @aviator19941 I added you guys as reviewers but its not ready yet, some cleanup to do, just as an fyi