Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the pickles to a special collection #219

Open
ekaf opened this issue Jul 22, 2024 · 7 comments
Open

Move the pickles to a special collection #219

ekaf opened this issue Jul 22, 2024 · 7 comments

Comments

@ekaf
Copy link
Contributor

ekaf commented Jul 22, 2024

Now that alternative data packages are available for all the pickles,
the question arises: what to do with the old packages?

Simply removing them seems very unsafe for those users who are stuck with an old NLTK version which they cannot upgrade, because they would be forced to look elsewhere to get those packages from dubious sources.

So, what about moving them to a special collection, named for ex. "Pickles"?

@hteeyeoh
Copy link

means old nltk data will renamed as something else and latest one we can remain using punkt to download instead using punkt_tab? cause we saw some other modules underlying using old nltk lib. if they didnt move forward, they will still using old nltk version that download the data via punkt instead punkt_tab

@ekaf
Copy link
Contributor Author

ekaf commented Aug 19, 2024

@hteeyeoh , the collections are xml files that provide thematic lists of nltk packages. I am proposing to move the pickles to a new list, while keeping their current https address, so that nothing breaks.

@hteeyeoh
Copy link

i see. So this means that for modules that did not upgrade nltk version they can still use punkt lib without triggering the security scan?

@ekaf
Copy link
Contributor Author

ekaf commented Aug 20, 2024

Yes, @hteeyeoh, one purpose of this issue is to discuss how to handle the case when users cannot upgrade to a newer NLTK version.

@hteeyeoh
Copy link

Thanks. May I know when can we have this ready?

@stevenbird
Copy link
Member

@hteeyeoh this is not a time-critical issue, so no promises. I suggest you use whichever punkt package you need.

@hteeyeoh
Copy link

Hi @stevenbird ,
Ya understand that. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants