Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete keys out of Layout YAML #52

Open
lukecyca opened this issue Nov 7, 2024 · 5 comments
Open

Unable to delete keys out of Layout YAML #52

lukecyca opened this issue Nov 7, 2024 · 5 comments

Comments

@lukecyca
Copy link

lukecyca commented Nov 7, 2024

Grafana: 11.3.0
Plugin: 1.8.1

It seems that whenever I make changes to the Layout YAML textarea on the sidebar, removing anything fails to take effect, and gets re-added as soon as I save/refresh.

My workaround is to never delete keys, but instead change them back to their default value.

@jacksongoode
Copy link
Collaborator

Hmmm, I'm not exactly sure what you mean here or I can't reproduce it. The YAML text area has changes immediately reflected when I make changes to it.

Could you post some minimal example?

@lukecyca
Copy link
Author

lukecyca commented Nov 7, 2024

Thanks for your reply! Sure, here are some screencasts:

In the first screencast:

  1. Create a new panel on a new dashboard
  2. Enter some hard-coded test data (although I experience this with dynamic data too)
  3. Notice that the x axis is type: date
  4. Attempt to delete it
  5. Notice that it has not taken effect
  6. Add a type: linear back
  7. Notice that it takes effect immediately
grafana-plotly-issue-1.mov

In the next screencase:

  1. Remove the type: date line
  2. Attempt to save this change in the dashboard. Grafana won't let me because it doesn't think any state has changed on this dashboard.
  3. Make an unrelated change to the panel description
  4. Save the dashboard
  5. Reload my browser
  6. Notice that type: date has reappeared!
grafana-plotly-issue-2.mov

@jacksongoode
Copy link
Collaborator

jacksongoode commented Nov 8, 2024

Ah I see what you mean. There are a few defaults that are set in the layout config that will default to if they aren't explicitly set. Those are what you see in the default layout editor in a new panel.

The other thing I notice is that you need to click away from the edits you've made in a textarea to actually commit them to the changes of the panel.

@jacksongoode
Copy link
Collaborator

Oddly, I don't see the behavior of not seeing changes to the x axis using a random walk dataset when you change the date type.

Screen.Recording.2024-11-07.at.17.15.21.mov

@jacksongoode
Copy link
Collaborator

However I am on 11.1 - let me just see if its an issue in 11.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants