Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [[deprecated]] to cu::Context #292

Open
csbnw opened this issue Jul 19, 2024 · 1 comment
Open

Add [[deprecated]] to cu::Context #292

csbnw opened this issue Jul 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@csbnw
Copy link
Contributor

csbnw commented Jul 19, 2024

Is your feature request related to a problem? Please describe.
Now that cudawrappers supports HIP, cu::Context only properly works when using CUDA as a backend and are executed as no-ops with HIP.

Describe the solution you'd like
We may want to discourage users from using these functions even with CUDA by adding [[deprecated]] tags.

Describe alternatives you've considered
N.A.

Additional context
Contexts are deprecated in HIP: https://rocm.docs.amd.com/projects/HIP/en/develop/doxygen/html/group___context.html

@csbnw csbnw added the enhancement New feature or request label Jul 19, 2024
@csbnw csbnw changed the title Add [[deprecated Add [[deprecated]] to cu::Context Jul 19, 2024
@loostrum
Copy link
Member

Requires C++14, so blocked by #186

@loostrum loostrum removed the blocked label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants