Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the library to be consumed from client side #11

Open
nitzano opened this issue Jul 14, 2018 · 1 comment
Open

Allow the library to be consumed from client side #11

nitzano opened this issue Jul 14, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@nitzano
Copy link
Owner

nitzano commented Jul 14, 2018

Describe the solution you'd like

We want the o use enum-converter from client-side, for that there
there should be added a solution for consuming from web (currently buggy).
Solution can be either be by code or adding appropriate documentation.

Is your feature request related to a problem? Please describe.

Yes, enum converter cannot be consumed/compiled from web applications.

Additional context

@nitzano nitzano added enhancement New feature or request and removed enhancement New feature or request labels Jul 14, 2018
@amitzur
Copy link

amitzur commented Nov 21, 2018

Working on this at #goodnessSquad event

I believe it may be possible to run browserify on a file that imports and exports convertString.
In order to simulate fs we can use browserify-fs and run something like:

browserify ./src/browser.s -r browserify-fs:fs -o ./lib/enum-converter.browser.js

But the problem is that is simulates only the async API. So we should change writeFileSync to be writeFile, preferably also using promisify with async/await.

Also this will also probably require babelify and maybe other browserify plugins.

I will give this a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants