Fixed some accessibility issues #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </a> | ||
| </div> | ||
| </div> | ||
| <div class="work__image-box"> | ||
| <img src="./images/project-2.png" class="work__image" alt="Project 1" /> | ||
| <img src="./images/project-2.png" class="work__image" alt="Image showcasing Calculator Project" /> |
There was a problem hiding this comment.
nisarhassan12
requested changes
Jul 18, 2020
|
Also, I just noticed that the buttons in "About Me" and "Get in Touch" have now turned into full black. Please also revert them back to the primary pink.
|
|
Alright I'll have desaturate the pink for more contrast and also remove "image and photo" words from alt text ! Thanks for reviewing I'm learning a lot about accessibility from this ! |
Co-authored-by: Nisar Hassan Naqvi <[email protected]>
Co-authored-by: Nisar Hassan Naqvi <[email protected]>
|
@Vikram-Hegde Can you please resolve the conflicts via rebasing on top of the latest master? Also please disable prettier. And also with your changes in place, there is now a glitch and the buttons are hidden by default in the about and Contact Section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2