Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctester doesn't use utf-8 for formParams #683

Open
davidgiga1993 opened this issue Jun 12, 2020 · 0 comments
Open

Doctester doesn't use utf-8 for formParams #683

davidgiga1993 opened this issue Jun 12, 2020 · 0 comments

Comments

@davidgiga1993
Copy link

Issue

When using the NinjaDocTester with .formParameters() the payload is not encoded as utf-8.
The root cause is in TestBrowserImpl:161:

UrlEncodedFormEntity entity = new UrlEncodedFormEntity(formparams);

The constructor is not called with any encoding.

Solution

The encoding should be added

UrlEncodedFormEntity entity = new UrlEncodedFormEntity(formparams, StandardCharsets.UTF_8);

I've added this issue here since it seems that the DocTester repo is inactive for the last 3 years. So maybe we can find a solution in Ninja for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant