Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to use streams as attachments [sf#7] #6

Open
nilnull opened this issue Apr 15, 2019 · 0 comments
Open

Be able to use streams as attachments [sf#7] #6

nilnull opened this issue Apr 15, 2019 · 0 comments
Labels
help wanted Extra attention is needed
Milestone
2.0

Comments

@nilnull
Copy link
Owner

nilnull commented Apr 15, 2019

Reported by nilnull on 2015-04-06 12:52 UTC
One of the constructors for Attachment allows for supplying a content stream, but the constructors for MimeAttachment hide this and make it unusable.
@nilnull nilnull self-assigned this Apr 15, 2019
@nilnull nilnull added this to the 2.0 milestone Apr 15, 2019
@nilnull nilnull changed the title Be able to use streams as attachments Be able to use streams as attachments [sf#7] Apr 15, 2019
@nilnull nilnull added the help wanted Extra attention is needed label Sep 4, 2019
@nilnull nilnull removed their assignment Feb 4, 2022
carlosbet added a commit to carlosbet/AIM that referenced this issue Jun 29, 2022
@carlosbet
Fix: e-mail attachments problems
cf4022b 
Based (but adapted and improved) on my old changes at sourceforge:
@see: https://sourceforge.net/u/cbello/netimplicitssl/ci/3d8ac39620390e9ff7f8c1fbaf1ab55f2d94fc4f/

I was asked to make a pull request of my changes, but I'm never did it.
Sorry.

- Small fixes in e-mail attachment headers.
- Used attachment.name property instead of FileName for set the
attachment name.
- Now we can use ignored property NameEncoding for set encoding of the
attachment name.
- Refactor constructors of MimeAttachment class. Note: ContentType
property it's initialized in the base class constructors and should not
be reassigned.

With these changes, works in the similar way as the original
System.Net.Mail does and fix nilnull#6
@carlosbet carlosbet mentioned this issue Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Fix: e-mail attachments problems carlosbet/AIM
1 participant
@nilnull