Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error on non-Linux systems #9

Open
jgalenson opened this issue Nov 8, 2013 · 1 comment
Open

Fix compilation error on non-Linux systems #9

jgalenson opened this issue Nov 8, 2013 · 1 comment

Comments

@jgalenson
Copy link

The most recent commit (37dc6c6) breaks builds on non-Linux systems (or on Linux builds using Emscripten, which is how I hit it). Specifically, it adds a parameter to the Minisat::memUsedPeak function in utils/System.h but only modifies one version in utils/System.cc (under #if defined(linux)). The other copies of the function do not have the extra parameter and so no not compile.

The easiest fix is to simply modify the other three versions of this function to have the extra parameter, which they then ignore. A smarter implementation would of course use the parameter.

@Siesh1oo
Copy link

The unused parameter should also be void-casted to avoid the "unused parameter"-compiler-warning.

conp-solutions referenced this issue in conp-solutions/mergesat Apr 6, 2018
Resolution for bug tracker issues #1, #4, #9, #10, #12, #13, #14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants