Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] - Add parent commit IDs to build details under Settings #311

Open
bjornoleh opened this issue Jun 16, 2024 · 2 comments · May be fixed by #312
Open

[feature request] - Add parent commit IDs to build details under Settings #311

bjornoleh opened this issue Jun 16, 2024 · 2 comments · May be fixed by #312
Assignees
Labels

Comments

@bjornoleh
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If people make the slightest changes to their builds, the commit ID will not show where they are in terms of syncing with Trio upstream. If we add parent commit refs to the build details displayed at the top of Settings view, we will probably be able to se recent merges with Trio main/dev/alpha as parent commits.

Describe the solution you'd like

Make minor adjustments to the current code for getting and displaying build details

Describe alternatives you've considered

List and describe any alternative solutions or features you've considered that could also address the problem. Explain why you believe the proposed solution is the best option.

Additional context

Include any other context, screenshots, or relevant information that might help in understanding the issue or the proposed solution. If applicable, describe any previous discussions or decisions that relate to this feature request.

Technical Details

If applicable, provide any technical details or considerations that might impact the implementation of this feature. This could include dependencies, potential risks, or required changes to existing functionalities.

User Impact

(Optional) Describe the impact of this issue on your use of the Trio app. Include any specific examples or data that demonstrate how widespread or severe the problem is.

@bjornoleh bjornoleh added enhancement New feature or request needs-triage labels Jun 16, 2024
@bjornoleh bjornoleh self-assigned this Jun 16, 2024
@bjornoleh bjornoleh added this to Trio Jun 16, 2024
@bjornoleh bjornoleh linked a pull request Jun 16, 2024 that will close this issue
mountrcg pushed a commit to mountrcg/Trio that referenced this issue Aug 1, 2024
Copy link

hey 👋 - no triage is done for 30 days 🤐 ... anybody? triage is required!

@github-actions github-actions bot added the stale label Aug 18, 2024
@bjornoleh
Copy link
Contributor Author

I think @dnzxy said this could be useful when supporting users that make their own changes. If we improve the build/versioning info that is displayed in Trio in line with what @bjorkert made for Loop Follow, we might want to incorporate the parent commit info there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant