Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer column Total Artwork #352

Open
PanderMusubi opened this issue Jul 20, 2015 · 7 comments
Open

Offer column Total Artwork #352

PanderMusubi opened this issue Jul 20, 2015 · 7 comments

Comments

@PanderMusubi
Copy link

PanderMusubi commented Jul 20, 2015

Please offer a column called "Total Artwork" which will be available after setting songbird.columnpicker.allowSecondaryProperties in about:config to true. This column would report per file the number of artwork files that are contained in the ID3 data. When no artwork is found, 0 is show. When a single artwork is found, 1 is shown. When multiple artwork is found, that specific number is shown.

Implementing this would enable a user to quickly identify what files have multiple artwork and if that is unwanted, fix this with another ID3 editor such as EasyTAG.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24637529-offer-column-total-artwork?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F230233&utm_medium=issues&utm_source=github).
@PanderMusubi
Copy link
Author

Also "Artwork #" may be used as label fo the column to save column width. (Same is done for "Track Number" vs. "Track #".)

@freaktechnik
Copy link
Member

I am not sure we have this info - especially since our tags API is a generalization for ID3 and other tag systems. Further the album art might also be coming from a file (see the rules in the album art settings).

@PanderMusubi
Copy link
Author

This would only apply to album art originating from ID3. EasyTAG can report it (probably using another API). Note, it does not need to retrieve all the album art, only count the total number. Is that possible with the current ID3 API?

@freaktechnik
Copy link
Member

The data we have for sorting playlists is listed in this file: https://github.com/nightingale-media-player/nightingale-hacking/blob/sb-trunk-oldxul/components/property/src/sbStandardProperties.h. There are plans to change the database scheme to support multiple values for some properties, but that's a lot of work and probably not happening in the short term.

@PanderMusubi
Copy link
Author

@rsjtdrjgfuzkfg
Copy link
Member

@PanderMusubi nope, have a look at this file instead:
https://github.com/nightingale-media-player/nightingale-hacking/blob/sb-trunk-oldxul/components/mediacore/metadata/handler/taglib/src/MetadataHandlerTaglib.cpp

Either way, implementing this is a rather big amount of work, and would require major changes. I'd suggest to wait until multiple values per tag value are technically possible, then such a column would be rather trivial, but for now multiple tag values are only visible within the metadata handler (as the library cannot handle them).

Right now, one would need to create a separate field for this information, which is not really a good design: If doing so, we'd also need number of artists, number of composers, etc (basically number of every tag that can have multiple values) -- else we'd have a very inconsistent representation imho. Also, this information does not really help the user (or worse, is confusing / misleading), as our tag writing code cannot handle these types of metadata at all and multiple tags might get deleted / summarized while writing an unrelated field.

@PanderMusubi
Copy link
Author

Thanks for the elaboration. Still the functional requirement for bulk reviewing metadata to find oddities, omissions and errors remains. If you have alternatives, I am also interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants