Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version string to all outgoing messages #54

Open
ssiloti opened this issue Jun 2, 2017 · 1 comment
Open

Add a version string to all outgoing messages #54

ssiloti opened this issue Jun 2, 2017 · 1 comment

Comments

@ssiloti
Copy link

ssiloti commented Jun 2, 2017

BEP 5 has been updated to document the long standing de-facto standard of including a version string in RPC messages. This is an important feature for identifying implementations which may be lacking features or misbehaving. The relevant section of BEP5:

A key v should be included in every message with a client version string. The string should be a two character client identifier registered in BEP 20 followed by a two character version identifier.

The convention is for the client identifier to identify the DHT implementation rather than the client application. Thus the same identifier should be used regardless of which client is using this module.

@nictuku
Copy link
Owner

nictuku commented Jun 21, 2017

I'd gladly accept a PR that implements this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants