Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[BUG]: List of breaking changes or how to update to ngxs 18 #2176

Open
rbirkgit opened this issue Jun 19, 2024 · 2 comments
Open

🐞[BUG]: List of breaking changes or how to update to ngxs 18 #2176

rbirkgit opened this issue Jun 19, 2024 · 2 comments

Comments

@rbirkgit
Copy link

Affected Package

ngxs 18

Is this a regression?

Description

I cannot find any information of any breaking changes in ngxs 18 or how to update to it. I tried just updating the versions but getting compile errors with signature changes.

🔬 Minimal Reproduction

Updating my project form 3.8.2 to 18.0.0

🔥 Exception or Error


Error: libs/automation-shell/src/lib/store/automation-sub-service.state.ts:36:4 - error TS1270: Decorator function return type 'void | DescriptorWithNoInjectedState<[typeof AutomationSubServiceState, (state: AutomationEnvironmentStateModel) => boolean, (routerState: RouterStateModel) => string | undefined, (state: CspStateModel) => CspSubServiceMap | undefined, (state: IdentityStateModel) => CspSubServiceMap | ...' is not assignable to type 'void | TypedPropertyDescriptor<(state: AutomationSubServiceStateModel, isOnPrem: boolean, servicePath: string, cspAccessableSubServiceMap: CspSubServiceMap, identityAccessableSubServiceMap: CspSubServiceMap) => AutomationSubService | undefined>'.

Environment


Libs:
- @angular/core version: 17.3.10
- @ngxs/store version: 18.0.0

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 20.13.0
- Platform:  Windows

Others:

@hakimio
Copy link
Contributor

hakimio commented Jul 4, 2024

The upgrade guide is here.
I don't know why @markwhitfeld hasn't officially published it yet.

EDIT: maybe because of #2179

@markwhitfeld
Copy link
Member

Yes, the NGXS v18 launch has been a "soft launch" so far.
We are getting early feedback (like the issue above) and looking at where our documentation and release announcement can be improved before publicising the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants