Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions-executing plug-in is not working as expected with nx monorepo ! #15

Open
HD60Hz opened this issue Jun 23, 2022 · 9 comments
Open

Comments

@HD60Hz
Copy link

HD60Hz commented Jun 23, 2022

We recently moved our Angular project into a monorepo (nx). we noticed that the action execution plugin no longer works!
are there any special configurations when it comes to using this kind of architectures, especially with shared libraries etc. ?

@joaqcid
Copy link
Member

joaqcid commented Dec 11, 2022

hi @HD60Hz i use this plugin myself with Nx without any issues, can you be more specific what issue you are having?

btw, sorry for late response

@joaqcid
Copy link
Member

joaqcid commented Apr 4, 2023

closing the issue, if you still are having problem please post more details and if possible a stackblitz with the error repro.

thanks @HD60Hz

@joaqcid joaqcid closed this as completed Apr 4, 2023
@MahmoudTarekAli
Copy link

MahmoudTarekAli commented Oct 17, 2024

Facing the Same issue here after i moved my angular project to nx workspace the action execution plugin no longer works! it always returns false and doesn't detect the changes which should be false => true => false
and hasActionsExecuting return undefined

this.store
   .select((state) => state['hasActionsExecuting'])
   .subscribe((data) => {
     console.log('Actions Executing:', data);
   });

   

@joaqcid
Copy link
Member

joaqcid commented Oct 17, 2024

hi @MahmoudTarekAli

that is not how you are supposed to use the actionExecuting plugin

Please refer to the documentation

But generally speaking you would
this.store.select(hasActionsExecuting([ACTION]))

@MahmoudTarekAli
Copy link

MahmoudTarekAli commented Oct 17, 2024

Okay but I am also using the @select decorator but facing the same issue, so is this not working anymore ?

@select(hasActionsExecuting([GetFeaturedArenas]))
getFeaturedArenasIsExecuting$: Observable;

@MahmoudTarekAli
Copy link

and after using this
this.store.select(hasActionsExecuting([ACTION]))

it also keeps return only false not false => true => false

@joaqcid
Copy link
Member

joaqcid commented Oct 22, 2024

@MahmoudTarekAli yes, the plugin works with NX, my project uses nx version 17 and works ok.

what versions of nx, ngxs and actions-executing plugin are you using?

would you be able to create a repo with a reproducible error?

@joaqcid joaqcid reopened this Oct 22, 2024
@joaqcid
Copy link
Member

joaqcid commented Oct 22, 2024

@MahmoudTarekAli @HD60Hz NX shouldnt change anything about how this plugin works, the only thing i would make sure is what angular version you are using and making sure is aligned with the ivy or non-ivy version of the plugin

@joaqcid
Copy link
Member

joaqcid commented Oct 30, 2024

@MahmoudTarekAli you still have issue with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants