Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific Errors and Warnings for Unsupported Ingress Configurations #176

Open
3 tasks
alex-bezek opened this issue Mar 13, 2023 · 1 comment
Open
3 tasks
Labels
enhancement New feature or request priority/low

Comments

@alex-bezek
Copy link
Collaborator

Description

There are some portions of the ingress spec which we do not support. Because of how ingress objects merge to form edges, there are also combinations of ingress objects that cause conflicts.

In the driver's sync function, we should collect any of these issues and emit logs and events signaling to the user the issue. These include the following:

  • Default backends are not supported and will be dropped transparently
  • Rules without hostnames are not supported and will be dropped transparently
  • If 2 ingress objects have the same rule host and path, they will conflict. The one processed first will be dropped.

Use Case

While there will be other types of errors and misconfigurations, this covers the known "surprising" issues that are in the ingress spec but not supported, or have implementation-specific details.

Related issues

No response

@alex-bezek alex-bezek added enhancement New feature or request needs-triage Issues that need triage labels Mar 13, 2023
@alex-bezek
Copy link
Collaborator Author

It might also be worth ordering all the ingress objects by timestamp as noted in

https://kubernetes.github.io/ingress-nginx/how-it-works/#building-the-nginx-model

Order Ingress rules by CreationTimestamp field, i.e., old rules first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low
Projects
None yet
Development

No branches or pull requests

1 participant