Make TippyDirective extendable #130
Unanswered
hagenstrahl
asked this question in
Ideas
Replies: 1 comment
-
You're welcome to submit a PR |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I would like to extend from TippyDirective to add some custom behavior and keep the overall api the directive provides.
Sadly right now it's not extendable because of some missing types which are not exported in public api and accessing some properties is unintended because they are
private
.My idea is:
TIPPY_CONFIG
InjectionToken andTippyConfig
to public api (https://github.com/ngneat/helipopper/blob/0c30ffbb49e1339578964018cad2800e587e1857/projects/ngneat/helipopper/src/lib/tippy.types.ts)private
property and method in TippyDirectiveprotected
(https://github.com/ngneat/helipopper/blob/master/projects/ngneat/helipopper/src/lib/tippy.directive.ts)What do you think?
Beta Was this translation helpful? Give feedback.
All reactions