Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'trace' option in @ngneat/elf-devtools #296

Open
st-clair-clarke opened this issue Jul 2, 2022 · 5 comments
Open

Support for 'trace' option in @ngneat/elf-devtools #296

st-clair-clarke opened this issue Jul 2, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers package: devtools

Comments

@st-clair-clarke
Copy link

st-clair-clarke commented Jul 2, 2022

Which @ngneat/elf-* package(s) are relevant/releated to the feature request?

@ngneat/elf-devtools

Description

@ngneat/elf-devtools only support some options as documented here dev-tools.

Could we get support for 'trace' option as well please.

Thanks

Proposed solution

It would be handled similarly to the current options.

Alternatives considered

None

Do you want to create a pull request?

No

@NetanelBasal NetanelBasal added enhancement New feature or request good first issue Good for newcomers package: devtools labels Jul 3, 2022
@Eralmidia
Copy link

+1 Adding this would really push us to move from Akita to Elf.

@naaajii
Copy link

naaajii commented May 4, 2023

I believe this is fairly very simple as it should just add trace property in DevtoolsOptions & add the following code:

if (options.trace) {
      console.groupCollapsed(`[${displayName}]`);
      console.trace();
      console.groupEnd();  
}

but I'm unsure where would this go. 😅

@arvidOtt
Copy link
Contributor

Happy to receive feedback on #459 👍 (it's my first contribution to Elf)

@arvidOtt
Copy link
Contributor

@st-clair-clarke @NetanelBasal PR #459 was merged. Can this issue be closed now?

@bhuber2010
Copy link

#459 only logs on store add or remove, not really that helpful. A full trace as in regular redux devtools expects (via trace option) seems to require much deeper work. Adding the option manually (ignored typing for the test) just gives the base observable stack, when only 10 calls are shown by default. And it slows things down greatly already.

Not sure I have time to dig deeper to try and figure out a solution, but if someone does, that'd be amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers package: devtools
Projects
None yet
Development

No branches or pull requests

6 participants