feat: 🎸 added option to handle prev/next button in the browser #31
Conversation
|
|
|
Please add test |
| const { queryKey } = def; | ||
| const queryParamValue = queryParams.get(queryKey); | ||
|
|
||
| if (!queryParamValue) continue; |
There was a problem hiding this comment.
removed.
When using updateOn: 'submit', need to clear form controls to prev state
There was a problem hiding this comment.
Why removed? can you please elaborate? I don't understand from your comment
| @@ -50,8 +50,8 @@ export class QueryParamDef<QueryParams = any> { | |||
| return serializedValue === '[object Object]' ? JSON.stringify(controlValue) : serializedValue; | |||
| } | |||
|
|
|||
| parse(queryParamValue: string) { | |||
| if (this.parser) { | |||
| parse(queryParamValue: string | null) { | |||
There was a problem hiding this comment.
do not pass null(undefined) values to custom parser function. Otherwise it causes breaking changes
There was a problem hiding this comment.
I'm not sure I understand your comment, why do you need this change?
|
@NetanelBasal done |
|
@shaharkazaz please check this |
|
:) |
|
@akaNightmare didn't forget that, I'm on vacation 😀 |
| parse(queryParamValue: string) { | ||
| if (this.parser) { | ||
| parse(queryParamValue: string | null) { | ||
| if (this.parser && queryParamValue != null) { |
There was a problem hiding this comment.
| if (this.parser && queryParamValue != null) { | |
| if (this.parser && queryParamValue !== null) { |
| @@ -50,8 +50,8 @@ export class QueryParamDef<QueryParams = any> { | |||
| return serializedValue === '[object Object]' ? JSON.stringify(controlValue) : serializedValue; | |||
| } | |||
|
|
|||
| parse(queryParamValue: string) { | |||
| if (this.parser) { | |||
| parse(queryParamValue: string | null) { | |||
There was a problem hiding this comment.
I'm not sure I understand your comment, why do you need this change?
| const { queryKey } = def; | ||
| const queryParamValue = queryParams.get(queryKey); | ||
|
|
||
| if (!queryParamValue) continue; |
There was a problem hiding this comment.
Why removed? can you please elaborate? I don't understand from your comment
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
closes #13