Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: dont require mac users to install additional versions of coreutilities #1251

Open
Tracked by #1276
avahahn opened this issue May 7, 2024 · 4 comments
Open
Tracked by #1276

Comments

@avahahn
Copy link
Contributor

avahahn commented May 7, 2024

The tools/unitctl should work just fine with whatever make, sed, awk that OSX ships with.

@danielledeleo
Copy link
Contributor

danielledeleo commented May 8, 2024

What about adding an auto target (like the rest of Unit's makefiles) for unitctl since those work fine on macOS?

Alternatively, since the unitctl Makefiles make heavy use of GNU Make 4.x features, we could detect if gmake is present in the path, use it transparently if present, and if not be minimally helpful and suggest:

brew install make gnu-sed grep coreutils

@danielledeleo
Copy link
Contributor

At the end of the day the main thing the Makefiles do is invoke cargo build and all that needs is a Rust compiler. Maybe there's a hacky way to define that build target above the Make version checks?

The Maven dependency for openapi-generator is another thing to look out for.

@danielledeleo
Copy link
Contributor

Alternatively, as discussed with @avahahn, explore replacing everything with a custom build.rs script to manage the OpenAPI dependencies.

@ac000
Copy link
Member

ac000 commented May 8, 2024

What about adding an auto target (like the rest of Unit's makefiles) for unitctl since those work fine on macOS?

The auto/ stuff is driven via ./configure and is really just for configuring unit...

The key is to stick to POSIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📖 Backlog
Development

No branches or pull requests

3 participants