Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete transition into using poetry and more #287

Open
4 tasks done
ificiana opened this issue Oct 30, 2022 · 1 comment
Open
4 tasks done

Complete transition into using poetry and more #287

ificiana opened this issue Oct 30, 2022 · 1 comment

Comments

@ificiana
Copy link
Contributor

ificiana commented Oct 30, 2022

Describe the solution you'd like

As mentioned earlier by @ronnie-llamado in #235:
The PR accompanying this issue (#288) aims to complete the process. Moreover, it explicitly adds support for Python 3.11

Tasks

To Do

  • Move PyPI information (version, classifiers, etc) over to pyproject.toml
  • Remove extraneous pipenv files (when the transition is complete)
  • Update Makefile for versioning

Up for Discussion

  • [?] Add new GitHub Actions workflow to push the package to PyPI on a new tag
    I personally prefer the CLI commands for publishing, but if needed we can update the workflow as needed.

Extras

  • Add support for Python 3.11

Additional context

Testing the versioning system: Example Output

$ poetry version
pyhumps 3.8.0
$ make deploy-patch
  poetry version patch
  Bumping version from 3.8.0 to 3.8.1
  git commit -m 'Bump version: 3.8.0 → 3.8.1' pyproject.toml
  [master XXXXXXX] Bump version: 3.8.0 → 3.8.1
   1 file changed, 1 insertion(+), 1 deletion(-)
  .
  .  (omitting results)
  .
  poetry publish -r test-pypi
  # this is a mock deployment, published to TestPyPI
  
  Publishing pyhumps (3.8.1) to test-pypi
   - Uploading pyhumps-3.8.1-py3-none-any.whl 0%
   - Uploading pyhumps-3.8.1-py3-none-any.whl 57%
   - Uploading pyhumps-3.8.1-py3-none-any.whl 100%
   - Uploading pyhumps-3.8.1.tar.gz 0%
   - Uploading pyhumps-3.8.1.tar.gz 100%

pyhumps mock

image

@ificiana
Copy link
Contributor Author

ificiana commented Nov 7, 2022

  • [?] Add a new GitHub Actions workflow to push the package to PyPI on a new tag
    I prefer the CLI commands for publishing, but if needed we can update the workflow as needed.

https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#publishing-to-package-registries
@nficano this step needs the API key as a repo secret, we can use this workflow depending on what you're comfortable with...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant