-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] RO Crate Datamodel - ISA Profile: Add typed getter/setter APIs for known fields #433
Comments
github-actions
bot
added
the
Status: Needs Triage
This item is up for investigation.
label
Sep 5, 2024
@HLWeil what about static members that only have one argument? member this.Foo() = ...
static member foo () =
fun (a: A) -> a.Foo() or member this.Foo() = ...
static member foo (a: A) = a.Foo() ? |
ARCtrl/src/Core/Table/ArcTable.fs Line 429 in 8b4368a
Apparently we kept it consistent. Not sure though whether in this case consistency wins over special case usability. |
So this one it is? member this.Foo() = ...
static member foo () =
fun (a: A) -> a.Foo() I hate it tbh and would rather change the existing API, but i think this is something for the backlog as of #419 |
kMutagene
added a commit
that referenced
this issue
Sep 6, 2024
Merged
Merged
kMutagene
added a commit
that referenced
this issue
Oct 18, 2024
github-actions
bot
added
the
Status: Needs Triage
This item is up for investigation.
label
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up for #384 as we decided to have more fine-grained PRs/issues on this.
The ISA profile is implemented as classes, but we still need an ergonomic API to work with them programmatically (e.g. to query properties).
As per previous discussion with @HLWeil, here are some necessary implementation details:
The text was updated successfully, but these errors were encountered: