Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Change RO parsing #391

Open
Hannah-Doerpholz opened this issue Jun 25, 2024 · 2 comments
Open

[Feature Request] Change RO parsing #391

Hannah-Doerpholz opened this issue Jun 25, 2024 · 2 comments

Comments

@Hannah-Doerpholz
Copy link

Is your feature request related to a problem? Please describe.
Recently you added new parsing for the purls that should work to create the right purls correctly.

Describe the solution you'd like
The RO purls have been fixed, so the "standard" parser for these purls (obofoundry purls) should now work as well. You can see the full issue here: oborel/obo-relations#799 (comment)

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jun 25, 2024
@Freymaurer
Copy link
Collaborator

Is this something we SHOULD change back or MAY change back? Is there an advantage to one option?

@Hannah-Doerpholz
Copy link
Author

It's a MAY. It really depends only on the time it takes to use the PO_RO_MS specific parser compared to the general one. I thought, since the obofoundry links are maybe a bit easier to parse that might take a little bit less time. It's completely optional though.

@HLWeil HLWeil removed the Status: Needs Triage This item is up for investigation. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In discussion
Development

No branches or pull requests

3 participants