Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to use ARCtrl.Json in fable JavaScript environment #373

Closed
Freymaurer opened this issue Jun 11, 2024 · 6 comments
Closed

[BUG] Unable to use ARCtrl.Json in fable JavaScript environment #373

Freymaurer opened this issue Jun 11, 2024 · 6 comments
Assignees
Labels
JavaScript Native use from JavaScript Python Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Freymaurer
Copy link
Collaborator

We use conditional references for environment targetet json libs:

image

This works for native transpilation and testing, but not when referenced in another fable environment.

@Freymaurer Freymaurer self-assigned this Jun 11, 2024
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jun 11, 2024
@Freymaurer
Copy link
Collaborator Author

More:
image

@Freymaurer Freymaurer added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. JavaScript Native use from JavaScript Python and removed Status: Needs Triage This item is up for investigation. labels Jun 11, 2024
@Freymaurer
Copy link
Collaborator Author

we hotfixed this with ARCtrl.alpha.6.swate hotfix. This version does not include conditional python/javascript json dependency, instead it always depens on thoth.json.javascript

@Freymaurer Freymaurer pinned this issue Jul 8, 2024
@Freymaurer
Copy link
Collaborator Author

Freymaurer commented Jul 9, 2024

To publish swate prerelease, you can use:

  1. change ARCtrl.Json.fsproj dependencies to
<ItemGroup>
    <PackageReference Include="NJsonSchema" Version="10.8.0" />
    <PackageReference Include="Thoth.Json.Core" Version="0.2.1" />
    <PackageReference Include="Thoth.Json.Newtonsoft" Version="0.1.0" />
    <PackageReference Include="Thoth.Json.JavaScript" Version="0.1.0" />
  </ItemGroup>
  1. Comment out all runtests references
  2. build.cmd publishNugetPrerelease
  3. on request type swate.b
  4. on request give prerelease version

@HLWeil HLWeil assigned HLWeil and unassigned Freymaurer Aug 27, 2024
@HLWeil
Copy link
Member

HLWeil commented Aug 27, 2024

I'm currently investigating why it doesn't work in Fable. '

The problem lies already with the dependency resolver they use, https://github.com/phmonte/Buildalyzer.

@HLWeil
Copy link
Member

HLWeil commented Oct 23, 2024

Should be fixed since >=2.1.0-alpha.1 (#446)

@Freymaurer, can you confirm and close Issue?

@Freymaurer
Copy link
Collaborator Author

With ARCtrl.JavaAcript it is now working as intended

@HLWeil HLWeil closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Native use from JavaScript Python Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: Done
Development

No branches or pull requests

2 participants