Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing essential parameters for antismash #356

Closed
Darcy220606 opened this issue Apr 5, 2024 · 4 comments
Closed

Add missing essential parameters for antismash #356

Darcy220606 opened this issue Apr 5, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement Improvement for existing functionality

Comments

@Darcy220606
Copy link
Contributor

Description of feature

The new version of antismash requires essential parametrs that i would suggest to be included in the pipeline. Those are pfam2go --rre --tfbs at the moment i add them using ext.args in the default runs.

@Darcy220606 Darcy220606 added enhancement Improvement for existing functionality documentation Improvements or additions to documentation labels Apr 5, 2024
@jfy133
Copy link
Member

jfy133 commented Jul 3, 2024

@Darcy220606 does this still apply?

@jasmezz
Copy link
Collaborator

jasmezz commented Jul 18, 2024

I added those params to the pipeline in the above PR.
@Darcy220606 Do you have more description than what is given by the antismash --help? The documentation gives nothing 🙃 It would be nice to fill the params help text a bit more, but it is not a must.

@jasmezz jasmezz self-assigned this Jul 18, 2024
@Darcy220606
Copy link
Contributor Author

I added those params to the pipeline in the above PR. @Darcy220606 Do you have more description than what is given by the antismash --help? The documentation gives nothing 🙃 It would be nice to fill the params help text a bit more, but it is not a must.

They all basically add more annotation to the BGC to allow for better selection for downstream experimental processing:

  • pfam2go: maps the proteins to PFAM db.This helps annoate BGC modules with functional information based on the protein families they contain.
  • rre: predicts regulatory elements on the BGC that help in teh control of expression of the peptides/proteins
  • tfbs: predicts the transcription factor binding sites, again which helps in regulation of expression

@jasmezz
Copy link
Collaborator

jasmezz commented Jul 19, 2024

Done in #403

@jasmezz jasmezz closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants