-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated z-index to 0 for image component #3407
base: canary
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@naveen-nrj is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent change focuses on updating the z-index property of the image component within the theme directory. The z-index is altered from 10 to 0 to ensure that images do not overlap with other UI components such as a fixed header bar. Changes
Assessment against linked issues
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/core/theme/src/components/image.ts (1 hunks)
Additional comments not posted (1)
packages/core/theme/src/components/image.ts (1)
25-25
: LGTM! The z-index change is correct.The z-index of the
img
slot has been updated from 10 to 0, which aligns with the expected behavior described in issue #3400.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide the code you used to tested with.
Hey can you please give some more details as to what code is needed from me. Thanks |
@naveen-nrj how did you test it to ensure the original issue can be fixed with your change? |
Closes #3400
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit