Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: enforce_theme=default Disables Browser-Based Dark/Light Mode Detection #46217

Open
4 of 8 tasks
bromiesTM opened this issue Jul 1, 2024 · 2 comments
Open
4 of 8 tasks
Labels
1. to develop Accepted and waiting to be taken care of 29-feedback bug design Design, UI, UX, etc.

Comments

@bromiesTM
Copy link

bromiesTM commented Jul 1, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

When the enforce_theme parameter in config.php is set to default, Nextcloud does not automatically adjust the theme (dark mode or light mode) based on the browser's settings.

Steps to reproduce

  1. Set the enforce_theme parameter in config.php to default:
  2. Open Nextcloud in Browser and confirm default theme is enforced at settings/user/theming
  3. Observe that Nextcloud does not change its theme based on the browser's theme settings. (Dev Tools ⇾ Rendering ⇾ Emulate CSS media feature prefers-color-scheme)

Expected behavior

Nextcloud should automatically switch between dark mode and light mode based on the browser's theme settings when the enforce_theme parameter is set to default.

Installation method

None

Nextcloud Server version

29

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@bromiesTM bromiesTM added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jul 1, 2024
@kesselb
Copy link
Contributor

kesselb commented Jul 1, 2024

cc @susnux @skjnldsv

@PeterJGDe PeterJGDe added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 2, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Jul 3, 2024

Ah, we should just remove default from the example in config.sample.php.
Default is not a valid theme, enforcing it makes zero sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 29-feedback bug design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

4 participants