ignore empty fileIds #1615
Merged
ignore empty fileIds #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <[email protected]>
|
It may be worth to push this fix with high priority, seeing the files list come back empty is quite scary and might result in lost trust (see #46139 ) |
8 tasks
susnux
approved these changes
Jul 2, 2024
|
Error also present on v28, so target v30 and backport v29 + v28? |
|
If it helps, I tested this fix on Nextcloud 27.1.11 and 29.0.3 and posted my feedback on server#46196. |
|
/backport to stable29 |
|
/backport to stable28 |
joshtrichards
approved these changes
Jul 6, 2024
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix generation of empty AND (()) request
Closes nextcloud/server#46196