Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe allow user to decide on how to adjust #134

Open
AMCalejandro opened this issue Nov 10, 2022 · 2 comments
Open

Maybe allow user to decide on how to adjust #134

AMCalejandro opened this issue Nov 10, 2022 · 2 comments
Assignees
@bschilder
Labels
enhancement New feature or request

Comments

@AMCalejandro
Copy link
Contributor

MAGMA_Celltyping/R/calculate_celltype_associations.r

Line 136 in 8cb235f

"ZSTAT%s",

Hi Brian,

Please, read here from the MAGMA manual

image
@bschilder
Copy link
Collaborator

bschilder commented Mar 1, 2023 •
edited
Loading

I'm not really clear on what the request is here. Could you please explain what you're hoping for @AMCalejandro ?

Please use the Feature Request template.
https://github.com/neurogenomics/MAGMA_Celltyping/issues/new/choose

@bschilder bschilder self-assigned this Mar 1, 2023
@bschilder bschilder added the enhancement New feature or request label Mar 1, 2023
@AMCalejandro
Copy link
Contributor Author

Yes, so maybe instead of assuming that I want to adjust with a Zscore, giving the user some freedom to decide whether to adjust with Zscore or the log of the P-value ,...

It has been a while, I think that is what I had in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschilder bschilder

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bschilder @AMCalejandro