Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check fix for default theme #23

Open
tzmanics opened this issue Feb 18, 2022 · 3 comments
Open

check fix for default theme #23

tzmanics opened this issue Feb 18, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@tzmanics
Copy link
Contributor

fix made to avoid undefined for the BLOG_THEME

const blogTheme = data.theme || "default";

review fix to see how to best change.

@tzmanics tzmanics added the bug Something isn't working label Feb 18, 2022
@iamaseem
Copy link

I think the better option is to use ?? rather than ||

@Azadina
Copy link

Azadina commented Feb 21, 2022

Hs

@maxcell
Copy link
Contributor

maxcell commented Feb 22, 2022

I think the better option is to use ?? rather than ||

I think either is totally fine for this particular case, we want this to be a temporary solution.

Ideally we are able to set this default elsewhere and then build that into our deploy URL. This is all so we can make sure the wizard workflow works well for people!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants
@tzmanics @maxcell @iamaseem @Azadina and others