Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in peer message protocol should be discovered as soon as possible #258

Open
contrun opened this issue Oct 21, 2024 · 0 comments

Comments

@contrun
Copy link
Collaborator

contrun commented Oct 21, 2024

The error here #231 is actually caused by a breaking change in the peer message protocol. This is because we changed the fields of the NodeAnnouncement message. This breaking change goes undetected. Maybe we should add some test fixtures to assure that old messages are still correctly de-serialized and processed. In this specific case, we can save the old NodeAnnouncement and try to process it with newer code in a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant