Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom eslint settings not used #3211

Open
ClementDreptin opened this issue Jun 20, 2024 · 1 comment
Open

Custom eslint settings not used #3211

ClementDreptin opened this issue Jun 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ClementDreptin
Copy link

ClementDreptin commented Jun 20, 2024

Description

Passing custom settings to require("lspconfig").eslint.setup() doesn't seem to have any effect.

Config

-- Loaded with lazy.nvim
return {
  "neovim/nvim-lspconfig",
  config = function()
    require("lspconfig").eslint.setup({
      settings = {
        enable = false,
      },
    })
  end
}

Expected behavior

I expect eslint not to report any diagnostics.

Actual behavior

Eslint still reports diagnostics.

What I tried

  • This doesn't seem to be an issue with vscode-eslint-language-server because the enable option works as expected within vscode.
  • I tried to start from a LazyVim config and add custom settings to the eslint lsp, and I have the same problem.
  • I tried to pass different shapes of objects to setup, and nothing made a difference.
    • { settings = { enable = false } }
    • { settings = { eslint = { enable = false } } }
    • { enable = false }
    • { eslint = { enable = false } }

I don't know if this is a bug, or if I'm missing something. If this is just a misunderstanding of the configuration on my part, I'm sorry.

@ClementDreptin ClementDreptin added the bug Something isn't working label Jun 20, 2024
@martenmatrix
Copy link

I've also tried these solutions, however they did not seem to have an effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants