Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Improve service provider listing #528

Merged

Conversation

NicoleNitschke
Copy link
Contributor

@NicoleNitschke NicoleNitschke commented Sep 8, 2023

Like in #517 described, I improved the filter bar and made the keyvisual section a bit smaller for showing more content above-the-fold. The ninja-icon was replaced by a user-friendly text which explains the search results.

The optimized filters look cleaner now:

grafik

@crydotsnake crydotsnake changed the title Feature/service provider listing FEATURE: Improve service provider listing Sep 8, 2023
@crydotsnake crydotsnake linked an issue Sep 8, 2023 that may be closed by this pull request
NicoleNitschke and others added 6 commits September 8, 2023 15:43
…ivate/Translations/de/Main.xlf

Co-authored-by: Simon Krull <[email protected]>
* replace ninja icon for search results with an search results text
…' into feature/service-provider-listing

# Conflicts:
#	DistributionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/Translations/de/Main.xlf
#	DistributionPackages/Neos.NeosIo/Resources/Private/Scss/Organisms/_KeyVisual.scss
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good beside the list view.

Copy link
Member

@crydotsnake crydotsnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Sebobo
Copy link
Member

Sebobo commented Oct 17, 2023

@NicoleNitschke thx, looks good now, but the filters are not visible on mobile. Was that intentionally?

I noticed as I set a filter then switched to mobile and had no way to show all providers again.

@NicoleNitschke
Copy link
Contributor Author

@NicoleNitschke thx, looks good now, but the filters are not visible on mobile. Was that intentionally?

I noticed as I set a filter then switched to mobile and had no way to show all providers again.

@Sebobo Yes, this is how it works on live today and I didn't change it, because it was not part of this ticket. But I agree with you, I would like to have these options in the mobile version, too - so I could open a new issue for this topic to get this one finished. :)

@Sebobo Sebobo merged commit f1054c8 into neos:development Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development Service Provider Listing (Filters, Rearrangement)
3 participants