-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Improve service provider listing #528
FEATURE: Improve service provider listing #528
Conversation
* replace ninja icon for search results with an search results text
…provider listing
…ptimize spacings
DistributionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/Translations/de/Main.xlf
Outdated
Show resolved
Hide resolved
…ivate/Translations/de/Main.xlf Co-authored-by: Simon Krull <[email protected]>
* replace ninja icon for search results with an search results text
…ptimize spacings
…' into feature/service-provider-listing # Conflicts: # DistributionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/Translations/de/Main.xlf # DistributionPackages/Neos.NeosIo/Resources/Private/Scss/Organisms/_KeyVisual.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good beside the list view.
...butionPackages/Neos.NeosIo.ServiceOfferings/Resources/Private/JavaScript/ProviderListing.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@NicoleNitschke thx, looks good now, but the filters are not visible on mobile. Was that intentionally? I noticed as I set a filter then switched to mobile and had no way to show all providers again. |
@Sebobo Yes, this is how it works on live today and I didn't change it, because it was not part of this ticket. But I agree with you, I would like to have these options in the mobile version, too - so I could open a new issue for this topic to get this one finished. :) |
Like in #517 described, I improved the filter bar and made the keyvisual section a bit smaller for showing more content above-the-fold. The ninja-icon was replaced by a user-friendly text which explains the search results.
The optimized filters look cleaner now: