Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle run template copying when one run type is copied to another. #242

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

marchermans
Copy link
Contributor

This fixes an issue where the default working directory of a run was changed to the one of the template, even though a template was never created on the run type from which the working copy was cloned.

Added test to cover this behaviour.

…nother.

This fixes an issue where the default working directory of a run was changed to the one of the template, even though a template was never created on the run type from which the working copy was cloned.

Added test to cover this behaviour.
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Sep 9, 2024

  • Publish PR to GitHub Packages

Last commit published: d74439269e6c73a56eb2ea428b008c12c40fa023.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #242' // https://github.com/neoforged/NeoGradle/pull/242
        url 'https://prmaven.neoforged.net/NeoGradle/pr242'
        content {
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle', 'test-utils')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
        }
    }
}

@marchermans marchermans merged commit 28e9828 into NG_7.0 Sep 22, 2024
103 of 111 checks passed
@marchermans marchermans deleted the fix/template-apply-during-userdev branch September 22, 2024 12:59
@neoforged-releases
Copy link

🚀 This PR has been released as NeoGradle version 7.0.164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant