Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of NEP Number Assignment and Usage #173

Open
Jim8y opened this issue May 22, 2024 · 7 comments
Open

Standardization of NEP Number Assignment and Usage #173

Jim8y opened this issue May 22, 2024 · 7 comments

Comments

@Jim8y
Copy link
Contributor

Jim8y commented May 22, 2024

Proposing a standardized method for assigning and managing NEO Enhancement Proposal (NEP) numbers to address the logistical challenges involved with the naming and referencing of NEP drafts. Currently, NEP drafts cannot be assigned a permanent NEP number until the proposal is officially adopted, causing confusion and inefficiency. This proposal ensures each draft receives a unique and final NEP number upon submission.

Motivation

The current process for managing NEP numbers is cumbersome and inefficient, causing confusion and delays in the drafting and reviewing phases. Proposers often need to reference NEP numbers in their drafts and related documentation, but without a permanent number, this becomes a moving target until adoption. This proposal seeks to streamline the process by ensuring each draft receives a unique and final NEP number upon submission.

Specification

  • NEP Number Assignment:
    • Upon submission of a draft NEP, a unique NEP number will be assigned immediately.
    • This number will be considered used, regardless of the draft’s final status (adopted or not).
  • Usage of NEP Numbers:
    • Drafts must use their assigned NEP number in all references within the document.
    • When submitting a draft as a pull request (PR), the PR title must include the NEP number in the format: Draft NEP XX: [Title].
    • If a PR includes multiple drafts, the title format should be: Draft NEP XX and Draft NEP YY: [Title].

Rationale

By standardizing the assignment of NEP numbers at the submission stage, this proposal ensures clarity and consistency in how drafts are referenced and managed throughout their lifecycle. This method reduces ambiguity and simplifies the tracking and updating of proposals, making the NEP process more transparent and accessible.

Backwards Compatibility

This proposal does not introduce technical changes to the NEO protocol but modifies the procedural aspects of the NEP process. It is fully backward compatible as it only affects new submissions.

PR: #172

@shargon
Copy link
Member

shargon commented May 22, 2024

I think that is not a problem, we can change the number before merge

@Jim8y
Copy link
Contributor Author

Jim8y commented May 22, 2024

  1. We need to implement it, in code we need nep number. We need to update documents, in documents we need nep number.
  2. File name of the nep needs the nep number.
  3. We need assign nep number anyway, and for multiple nep drafts that is processing, you better hope you know what number to assign when you have to deal with 10 nep drafts.
  4. Face the reality, neocore is desperately inefficient, every extra step can prolong the reviewing process for weeks or months.

@cschuchardt88
Copy link
Member

cschuchardt88 commented May 23, 2024

Yes, should be the PR number. Every other blockchain uses this numbering system.

@EdgeDLT
Copy link

EdgeDLT commented May 23, 2024

Every other blockchain uses this numbering system

That's not true. Some might use PR numbers during draft stage but every network I have checked so far (including Bitcoin and Ethereum) define sequential numbering as the default. NEP-1 was basically a copy-paste of BIP-1 so it shouldn't come as a surprise.

Which blockchains use PR-based numbering for finalized proposals, and how does it benefit us to suddenly change it after 5 years?

@Jim8y
Copy link
Contributor Author

Jim8y commented May 23, 2024

I don't want to waste time discussing how the number should be. Just give me a solution that does not require me to keep updating the nep number, the file name, the related implementations. Cause every time we make update, we dismiss all existing approvals and will take another months to collect them again. Promise me you will give me approve again after i made your required change and AT you, or I will keep this plan.

@cschuchardt88
Copy link
Member

Every other blockchain uses this numbering system

That's not true. Some might use PR numbers during draft stage but every network I have checked so far (including Bitcoin and Ethereum) define sequential numbering as the default. NEP-1 was basically a copy-paste of BIP-1 so it shouldn't come as a surprise.

Which blockchains use PR-based numbering for finalized proposals, and how does it benefit us to suddenly change it after 5 years?

Ethereum and bitcoin use Issue number

@EdgeDLT
Copy link

EdgeDLT commented May 23, 2024

Ethereum and bitcoin use Issue number

That's the functional result of using sequential numbering and not re-using numbers when a proposal isn't finalized. It's not how BIP-1 or EIP-1 define how a number should be picked.

Just give me a solution that does not require me to keep updating the nep number, the file name, the related implementations

Each new proposal takes the next number. Don't reuse numbers. Never worry about numbers again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants