Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use devcontainer to run some CI tests #3347

Closed
wants to merge 4 commits into from
Closed

Conversation

vncoelho
Copy link
Member

Try to close #3319

@@ -113,7 +113,7 @@ jobs:
uses: actions/checkout@v4

- name: Build and run dev container task
uses: devcontainers/ci@v0.4
uses: devcontainers/ci@v0.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use v0.3.1900000349?

Copy link
Member Author

@vncoelho vncoelho Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, but what should be the nomenclature there? all these numbers?

Copy link
Member

@cschuchardt88 cschuchardt88 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vncoelho vncoelho marked this pull request as ready for review June 18, 2024 11:45
@vncoelho
Copy link
Member Author

Now the trick...Reverting commit 2bd2a45 and check if it will fail

@vncoelho
Copy link
Member Author

vncoelho commented Jun 18, 2024

Did not fail, publish or build command for testing is missing

@vncoelho vncoelho marked this pull request as draft June 18, 2024 12:07
@vncoelho
Copy link
Member Author

I am still not able to reproduce the local environment correctly

@vncoelho vncoelho closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Tests with CI / ACTION to ensure local build is working
2 participants