Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Session.Close #41

Open
nemith opened this issue May 5, 2023 · 0 comments
Open

Investigate Session.Close #41

nemith opened this issue May 5, 2023 · 0 comments
Labels
enhancement New feature or request investigation Needs some time to invesigate an isssue
Milestone

Comments

@nemith
Copy link
Owner

nemith commented May 5, 2023

I am pretty sure session.Close as implemented is a bit wrong. We are properly using <close-session> rpc message to gracefully close the session with the netconf server, however then we are closing the transports as well.

This should probably be modified to

  1. Send close-session
  2. Wait for timeout set by the context (and maybe a default if not set?)
  3. Wait for the session to close (on ssh this causes the channel to be closed, need to test if some vendors kill the entire connection)
  4. Never close the transport.

Transport is constructed outside of the session and passed in, it is a bit crazy that we automatically close it when the session is done as well. This is also needed to allow for transport reuse potentially.

@nemith nemith added enhancement New feature or request good first issue Good for newcomers investigation Needs some time to invesigate an isssue labels May 5, 2023
@nemith nemith added this to the 1.0 milestone May 5, 2023
@nemith nemith removed the good first issue Good for newcomers label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigation Needs some time to invesigate an isssue
Projects
None yet
Development

No branches or pull requests

1 participant